Fix reset button in examples #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Codecov Report
@@ Coverage Diff @@
## gz-sim8 #2151 +/- ##
===========================================
+ Coverage 65.43% 65.47% +0.03%
===========================================
Files 323 323
Lines 30704 30704
===========================================
+ Hits 20091 20102 +11
+ Misses 10613 10602 -11 |
ahcorde
approved these changes
Sep 15, 2023
mjcarroll
approved these changes
Sep 15, 2023
8 tasks
iche033
pushed a commit
that referenced
this pull request
Sep 20, 2023
Signed-off-by: Addisu Z. Taddese <[email protected]>
mjcarroll
pushed a commit
that referenced
this pull request
Sep 20, 2023
* Fix reset button in examples (#2151) Signed-off-by: Addisu Z. Taddese <[email protected]> * fix reset button in more world sdf files Signed-off-by: Ian Chen <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Having a hard coded width was causing the reset button to be cut off. I ran
sed -i '/width">121</d' ./examples/worlds/*.sdfsince the values are all the same. I haven't checked if there are sdf files with different widths in theWorldControlplugin.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸